Add cardinality_scope slot.
#476
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new mapping record slot called `cardinality_scope`, intended to precise the meaning of the value of the `mapping_cardinality` slot. If empty, it means that the cardinality is relative to the entire set (which corresponds to the current definition of `mapping_cardinality`, and therefore ensures backwards compatibility). If non-empty, it is expected to be a list of slots that are used to define the subset (the "scope") of mapping records in which the cardinality has been computed. For example, a cardinality scope of (`predicate_id`, `object_source`) means that the cardinality is computed over the subset of mapping records that have the same predicate and whose objects come from the same source. The new slot is propagatable, because it is assumed that in most mapping sets, the cardinality for all records will be computed in the same way (though there's no obligation for that), and so all records will share the same scope.
matentzn
reviewed
Jul 31, 2025
Collaborator
matentzn
left a comment
matentzn
left a comment
There was a problem hiding this comment.
This is a much welcome clarification of that field..
matentzn
previously approved these changes
Jul 31, 2025
ehartley
reviewed
Aug 1, 2025
ehartley
previously approved these changes
Aug 1, 2025
Contributor
ehartley
left a comment
ehartley
left a comment
There was a problem hiding this comment.
All the changes look good. My only suggestion is to update the list of propagatable slots in the spec-model.md file.
ehartley
approved these changes
Aug 1, 2025
matentzn
approved these changes
Aug 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves [#467]
docs/have been added/updated if necessarymake testhas been run locally[ ] tests have been added/updated (if applicable)If you are proposing a change to the SSSOM metadata model, you must
examples/see_alsofield of the linkml modelsee_alsofield of the linkml modeladded_inannotationThis PR adds a new mapping record slot called
cardinality_scope, intended to precise the meaning of the value of themapping_cardinalityslot.If empty, it means that the cardinality is relative to the entire set (which corresponds to the current definition of
mapping_cardinality, and therefore ensures backwards compatibility). If non-empty, it is expected to be a list of slots that are used to define the subset (the "scope") of mapping records in which the cardinality has been computed.For example, a cardinality scope of (
predicate_id,object_source) means that the cardinality is computed over the subset of mapping records that have the same predicate and whose objects come from the same source.The new slot is propagatable, because it is assumed that in most mapping sets, the cardinality for all records will be computed in the same way (though there's no obligation for that), and so all records will share the same scope.